-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Compare files manually. #710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm, I liked the idea of just closing the handle to the named temporary file and then using filecmp. |
Oh. It just seemed less clean. eg:
Granted, this is a bit more verbose and low-level, but I feel like it flows better. |
Can we just remove the file comparison altogether from this sample? |
382ef96
to
249a2f2
Compare
Oh yeah - sure. Apparently this file isn't even referenced in the docs anymore. |
import json | ||
import tempfile | ||
|
||
from googleapiclient import discovery | ||
from googleapiclient import http | ||
|
||
from oauth2client.client import GoogleCredentials | ||
from six.moves import zip_longest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. right.
Addresses #707