Skip to content

refactor: update gcs sample #7121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 29, 2021
Merged

refactor: update gcs sample #7121

merged 8 commits into from
Nov 29, 2021

Conversation

KaylaNguyen
Copy link
Contributor

Description

Update GCS sample to use declarative function signature.

Checklist

@KaylaNguyen KaylaNguyen requested a review from a team as a code owner November 17, 2021 04:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 17, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 17, 2021
@busunkim96 busunkim96 requested a review from engelke November 17, 2021 16:59
@leahecole leahecole requested a review from a team November 18, 2021 00:05
@busunkim96
Copy link
Contributor

@KaylaNguyen The tests seem to be failing with an import error:

ImportError while importing test module '/workspace/functions/v2/storage/main_test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/local/lib/python3.7/importlib/__init__.py:127: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
main_test.py:17: in <module>
    import main
main.py:15: in <module>
    import functions_framework
E   ModuleNotFoundError: No module named 'functions_framework'

Please put any packages are needed to run the sample in the requirements.txt: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/functions/v2/storage/requirements.txt

@google-cla google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 24, 2021
@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 24, 2021
@KaylaNguyen
Copy link
Contributor Author

Some how merging removed that change off my PR. Fixed.

engelke
engelke approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@engelke engelke merged commit 5cbed1b into GoogleCloudPlatform:master Nov 29, 2021
@KaylaNguyen KaylaNguyen deleted the gcs-sample branch November 29, 2021 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole Awaiting requested review from leahecole

@rachael-ds rachael-ds Awaiting requested review from rachael-ds

2 more reviewers

@engelke engelke engelke approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KaylaNguyen @busunkim96 @engelke @dandhlee