Skip to content

Fix flaky tests by running slow deletion as a background task #7159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 2, 2021
Merged

Fix flaky tests by running slow deletion as a background task #7159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
34842ad
Async deletion for cloud run
dinagraves Nov 24, 2021
cac7467
Memorystore async deletion for cloud run
dinagraves Nov 24, 2021
d24edc9
Merge branch 'master' into gcloud-async
dinagraves Nov 24, 2021
17ee9f8
Merge branch 'main' into gcloud-async
dinagraves Dec 1, 2021
904cc6a
Update auth_test.py
dinagraves Dec 1, 2021
60deaa3
Merge branch 'main' into gcloud-async
parthea Dec 2, 2021
f7cbc07
Merge branch 'main' into gcloud-async
leahecole Dec 2, 2021
57b4daa
Merge branch 'main' into gcloud-async
dinagraves Dec 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions auth/service-to-service/auth_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ def services():
[
"gcloud", "run", "services", "delete", f"helloworld-{suffix}",
"--project", project,
"--async",
"--platform=managed",
"--region=us-central1",
"--quiet",
Expand All @@ -96,6 +97,7 @@ def services():
[
"gcloud", "functions", "delete", f"helloworld-{suffix}",
"--project", project,
"--async",
"--region=us-central1",
"--quiet",
],
Expand Down
1 change: 1 addition & 0 deletions memorystore/redis/cloud_run_deployment/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ def deployed_service(container_image, redis_host):
"--platform=managed",
"--region=us-central1",
"--quiet",
"--async",
"--project",
PROJECT,
]
Expand Down
1 change: 1 addition & 0 deletions run/filesystem/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def deployed_service():
'--region=us-central1',
'--platform=managed',
'--quiet',
"--async",
'--project',
PROJECT,
]
Expand Down
1 change: 1 addition & 0 deletions run/hello-broken/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ def deployed_service(container_image):
"--platform=managed",
"--region=us-central1",
"--quiet",
"--async",
"--project",
PROJECT,
]
Expand Down
1 change: 1 addition & 0 deletions run/helloworld/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def deployed_service(container_image):
"--platform=managed",
"--region=us-central1",
"--quiet",
"--async",
"--project",
PROJECT,
]
Expand Down
1 change: 1 addition & 0 deletions run/image-processing/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ def deployed_service(container_image, output_bucket):
"--platform=managed",
"--region=us-central1",
"--quiet",
"--async",
"--project",
PROJECT,
]
Expand Down
1 change: 1 addition & 0 deletions run/logging-manual/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ def deployed_service(container_image):
"--platform=managed",
"--region=us-central1",
"--quiet",
"--async",
"--project",
PROJECT,
]
Expand Down
1 change: 1 addition & 0 deletions run/markdown-preview/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,7 @@ def renderer_deployed_service(renderer_image):
"--platform=managed",
"--region=us-central1",
"--quiet",
"--async",
"--project",
PROJECT,
]
Expand Down
1 change: 1 addition & 0 deletions run/pubsub/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ def deployed_service(container_image):
"--platform=managed",
"--region=us-central1",
"--quiet",
"--async",
"--project",
PROJECT,
]
Expand Down
1 change: 1 addition & 0 deletions run/system-package/e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ def deployed_service(container_image):
"--platform=managed",
"--region=us-central1",
"--quiet",
"--async",
"--project",
PROJECT,
]
Expand Down