Skip to content

Private Service Connect integration #7162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2021
Merged

Private Service Connect integration #7162

merged 2 commits into from
Nov 29, 2021

Conversation

jacek-izykowski
Copy link
Member

@jacek-izykowski jacek-izykowski commented Nov 26, 2021 •
edited by leahecole
Loading

Description

Mirrors cl/411490264 which has links to passing builds

Note: It's a good idea to open an issue first for discussion.

Checklist

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 26, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 26, 2021
@leahecole leahecole assigned leahecole and unassigned engelke Nov 29, 2021
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2021
@leahecole
Copy link
Collaborator

Thanks @jacek-izykowski !!

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2021
dandhlee
dandhlee approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leahecole leahecole merged commit 081b19b into GoogleCloudPlatform:master Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@dandhlee dandhlee dandhlee approved these changes

@rachael-ds rachael-ds Awaiting requested review from rachael-ds

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jacek-izykowski @leahecole @dandhlee @engelke @kokoro-team