Skip to content

refactor: update http sample #7193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2021
Merged

refactor: update http sample #7193

merged 4 commits into from
Dec 6, 2021

Conversation

KaylaNguyen
Copy link
Contributor

Description

Update http sample to use declarative function signature.

Checklist

@KaylaNguyen KaylaNguyen requested review from a team as code owners December 3, 2021 19:57
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 3, 2021
dandhlee
dandhlee approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nit: fix or feat might be a more appropriate prefix here

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Dec 6, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 78e0a1b into GoogleCloudPlatform:main Dec 6, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 6, 2021
@KaylaNguyen KaylaNguyen deleted the http-sample branch December 7, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees

@nicain nicain

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KaylaNguyen @leahecole @dandhlee @nicain