feat: Prevent overriding the value from config #7218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the DEBUG env var will always be overridden into True, while we already have a way to read it from env var. By setting the default value as True and not overridding the value later we can retainthe DEBUG value provided from the users.
0bc7bed to
3feb3c6
Compare
averikitsch
approved these changes
Dec 9, 2021
glasnt
approved these changes
Dec 9, 2021
dandhlee
requested changes
Dec 10, 2021
run/django/mysite/settings.py
Outdated
Comment on lines
64
to
65
| # SECURITY WARNING: don't run with debug turned on in production! | ||
| # Change this to "False" when you are ready for production |
There was a problem hiding this comment.
Could you move this warning up above to where it's set to True as well?
There was a problem hiding this comment.
Addressed your comment @dandhlee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #Previously the DEBUG env var will always be overridden into True, while
we already have a way to read it from env var. By setting the default
value as True and not overridding the value later we can retainthe DEBUG
value provided from the users.
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)