Skip to content

chore: add comment to cloudsql unix socket sample #7219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2021
Merged

chore: add comment to cloudsql unix socket sample #7219

merged 3 commits into from
Dec 9, 2021

Conversation

jackwotherspoon
Copy link
Contributor

Adding comment to code sample to clear up key name for psycopg2 driver/library.

@jackwotherspoon jackwotherspoon self-assigned this Dec 9, 2021
@jackwotherspoon jackwotherspoon requested a review from a team December 9, 2021 19:34
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner December 9, 2021 19:34
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 9, 2021
kurtisvg
kurtisvg suggested changes Dec 9, 2021
View reviewed changes
jackwotherspoon and others added 2 commits December 9, 2021 14:48
@jackwotherspoon @kurtisvg
chore: update comment
9845b3a 
Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
@jackwotherspoon
chore: fix linting
211ed87
@jackwotherspoon jackwotherspoon merged commit b04bd37 into main Dec 9, 2021
@jackwotherspoon jackwotherspoon deleted the patch-cloudsql-sample branch December 9, 2021 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

+1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jackwotherspoon jackwotherspoon

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackwotherspoon @enocom @kurtisvg