docs: Change Python client examples from sample_task to sampleTask #7231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahecole
approved these changes
Dec 15, 2021
kolea2
reviewed
Dec 16, 2021
| @@ -150,26 +150,26 @@ def incomplete_key(client): | |||
|
|
|||
| def named_key(client): | |||
| # [START datastore_named_key] | |||
| key = client.key("Task", "sample_task") | |||
| key = client.key("Task", "sampleTask") | |||
There was a problem hiding this comment.
LGTM! Could we add a test somewhere for these? CC @leahecole as I'm unfamiliar with this repo/structure :)
There was a problem hiding this comment.
Thanks. I've added tests to assert that the key.name == "sampleTask".
The examples in other client libraries are all using `sampleTask`. Additionally, the doc says: > The following example creates a key with kind Task using a key name, "sampleTask", as the identifier:
b400713 to
aa7b0c0
Compare
kolea2
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The examples in other client libraries are all using
sampleTask.Additionally, the doc says:
Closes internal bug 210583283
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)