Skip to content

Update grpc-bookstore.yaml #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2017
Merged

Update grpc-bookstore.yaml #734

merged 1 commit into from
Jan 4, 2017

Conversation

kyessenov
Copy link
Contributor

@kyessenov kyessenov commented Dec 21, 2016 •
edited
Loading

Fix GCR reference

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 21, 2016
@theacodes
Copy link
Contributor

Would love for @lookuptable to take a look before I merge.

@wenchenglu
Copy link

Hi, Kuat, since you are at this cl, please also update https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/endpoints/getting-started/container-engine.yaml to point to the new container image

@wenchenglu
Copy link

never mind, I created a separate pull request to update the quickstart sample (container-engine.yaml): #741

@kyessenov
Copy link
Contributor Author

Friendly ping?

@theacodes theacodes merged commit 352bd05 into GoogleCloudPlatform:master Jan 4, 2017
@kyessenov kyessenov deleted the patch-1 branch January 5, 2017 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lookuptable lookuptable lookuptable approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyessenov @theacodes @wenchenglu @lookuptable @googlebot