Skip to content

dataflow/tensorflow-landsat: remove conflicting flag #7343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 19, 2022
Merged

dataflow/tensorflow-landsat: remove conflicting flag #7343

merged 8 commits into from
Feb 19, 2022

Conversation

davidcavazos
Copy link
Contributor

Description

Fixes #6436

The machine_type flag conflicts with the worker_machine_type flag. The custom machine should use an N1 machine so the n1-standard-4 is not necessary.

Checklist

@davidcavazos davidcavazos requested a review from a team as a code owner January 10, 2022 19:45
@product-auto-label product-auto-label bot added api: dataflow Issues related to the Dataflow API. samples Issues that are directly related to samples. labels Jan 10, 2022
@tvalentyn
Copy link
Contributor

Thanks! Let's make the same change in other files changed in #6473 ? I think you have presubmits configured, right? so if tests fail, let's open an internal bug and investigate the rootcause.

@tvalentyn
Copy link
Contributor

took a closer look, this is LGTM as is.

@tvalentyn
Copy link
Contributor

tvalentyn commented Jan 10, 2022 •
edited
Loading

other files did not specify a custom machine type, so they became e2 machines

@tvalentyn
Copy link
Contributor

cc: @harrisonlimh

@tvalentyn tvalentyn mentioned this pull request Jan 10, 2022
Closed
@davidcavazos davidcavazos added the blunderbuss: assign Instruct blunderbuss to assign someone label Jan 11, 2022
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Jan 11, 2022
@loferris loferris self-requested a review January 14, 2022 18:51
@davidcavazos
Copy link
Contributor Author

Hi @loferris, can you take a look at this whenever you have a chance? Thanks!

@dandhlee dandhlee added the automerge Merge the pull request once unit tests and other checks pass. label Feb 19, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 42c054f into GoogleCloudPlatform:main Feb 19, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 19, 2022
@davidcavazos davidcavazos deleted the dataflow-conflicting-flag branch January 31, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

@loferris loferris Awaiting requested review from loferris

+2 more reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@tvalentyn tvalentyn tvalentyn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@loferris loferris

@dinagraves dinagraves

Labels
api: dataflow Issues related to the Dataflow API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dataflow.gpu-examples.tensorflow-minimal.e2e_test: test_tensorflow_minimal failed
7 participants
@davidcavazos @tvalentyn @busunkim96 @dandhlee @loferris @dinagraves @meredithslota