Skip to content

chore: Update Airflow 2 GKE sample to use regional clusters #7753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole commented Apr 5, 2022

Companion to cl/439518578 - we recommend using regional clusters not zonal clusters
Airflow success

Airflow 1 sample will not be updated to match due to the way the location functionality is implemented in Airflow 1. If customer want to use regional clusters, we recommend they upgrade to Airflow 2.

@leahecole leahecole requested a review from pavel-salnikov April 5, 2022 14:13
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 5, 2022
@leahecole leahecole force-pushed the cl/439518578 branch 2 times, most recently from 6346dd9 to d9d8d45 Compare April 19, 2022 17:51
@leahecole
Copy link
Collaborator Author

force push was removing Airflow 1 changes - we determined we don't need them

@leahecole leahecole marked this pull request as ready for review April 19, 2022 17:57
@leahecole leahecole requested review from rachael-ds, rafalbiegacz and a team as code owners April 19, 2022 17:57
@leahecole leahecole added the blunderbuss: assign Instruct blunderbuss to assign someone label Apr 19, 2022
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Apr 19, 2022
@leahecole
Copy link
Collaborator Author

leahecole commented Apr 20, 2022

Okay @parthea ! Ready for review # 2 😁

@parthea parthea changed the title Update Airflow 2 GKE sample to use regional clusters chore: Update Airflow 2 GKE sample to use regional clusters Apr 20, 2022
@leahecole
Copy link
Collaborator Author

Admin merging as Pavel was product reviewer

@leahecole leahecole merged commit 651c9cd into main Apr 20, 2022
@leahecole leahecole deleted the cl/439518578 branch April 20, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants