-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Reassert idp-sql and django tests #7779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gcf-merge-on-green
merged 7 commits into
GoogleCloudPlatform:main
from
glasnt:topic/tests
Apr 20, 2022
Merged
Reassert idp-sql and django tests #7779
gcf-merge-on-green
merged 7 commits into
GoogleCloudPlatform:main
from
glasnt:topic/tests
Apr 20, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averikitsch
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @glasnt
I'm on board w/ this as a temporary fix, but this looks like a good opportunity to use Terraform + fresh GCP projects. (Terraform abstracts away retries. We'd need to update our CI infrastructure, though. Googlers, see this link.) |
leahecole
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7342 introduced a change where nox would check for
test_*.py
and*_test.py
files. Django and IDP-SQL had their tests intest/
, so this glob didn't find these files, and these tests haven't been run for a bit.Outstanding issues with these tests:
dynamic PR status update follows
Debugging seems to indicate this happens on old versions of postgres. Django 4.0 no longer supports Postgres 9.6.
test-instance-pg
is Postgres 9.6, which is EOL as of November 2021.Suggest creating a newer versioned instance of a postgres testing database (happy to help here where I can).
Update: test-instance-pg has been updated to Postgres 14
This is being addressed as of v2.9.0 of flake8-annotations. sco1/flake8-annotations#136
It will require adding
--allow-star-arg-any
to the flake8 call.Update: while this flag could be used, I opted to use the
TypeVar
method in #7789Checklist
nox -s py-3.6
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)