Skip to content

Removes examples on non-cloud library #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gguuss
Copy link
Contributor

@gguuss gguuss commented Feb 2, 2017

No description provided.

@gguuss gguuss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 2, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2017
@gguuss
Copy link
Contributor Author

gguuss commented Feb 2, 2017

This is for speech, creating the CL a little proactively because we now have the transcribe / transcribe_async examples in cloud-client.

@theacodes
Copy link
Contributor

@gguuss typically we keep the api-client samples around for posterity. Do we absolutely not want users to have any samples for Speech using that client library? If so, then I'm fine with merging this.

@gguuss
Copy link
Contributor Author

gguuss commented Feb 2, 2017

@jonparrott A fair statement. If we want to keep them around, let's add usage examples to them.

@theacodes
Copy link
Contributor

@gguuss it leave it up to you.

@gguuss
Copy link
Contributor Author

gguuss commented Feb 2, 2017

I'm going to abandon branch and will add usage examples in a separate PR.

@gguuss gguuss closed this Feb 2, 2017
@gguuss gguuss deleted the remove-api-client branch February 2, 2017 23:06
Linchin added a commit that referenced this pull request Aug 18, 2025
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants