Skip to content

Fix monitoring tests #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2017
Merged

Fix monitoring tests #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16fd1a9
Fix monitoring tests
Feb 10, 2017
6acca5b
Replace test message
Feb 10, 2017
fb0f218
Fix message again
Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions monitoring/api/v3/cloud-client/quickstart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ def run_quickstart():

metric = client.metric(
type_='custom.googleapis.com/my_metric',
labels={
'status': 'successful',
}
labels={}
)

client.write_point(metric, resource, 3.14)
Expand Down
1 change: 0 additions & 1 deletion monitoring/api/v3/cloud-client/snippets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ def write_time_series():
metric = client.metric(
type_='custom.googleapis.com/my_metric',
labels={
'status': 'successful',
}
)
client.write_point(metric, resource, 3.14)
Expand Down
2 changes: 1 addition & 1 deletion monitoring/api/v3/cloud-client/snippets_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def test_create_get_delete_metric_descriptor(capsys):
snippets.create_metric_descriptor()
snippets.get_metric_descriptor('custom.googleapis.com/my_metric')
out, _ = capsys.readouterr()
assert 'a simple example' in out
assert "value_type='DOUBLE'" in out
snippets.delete_metric_descriptor('custom.googleapis.com/my_metric')
out, _ = capsys.readouterr()
assert 'Deleted metric' in out
Expand Down