Skip to content

Conversation

supersmo
Copy link
Contributor

@supersmo supersmo commented May 30, 2022

Description

Fixes #8022

Note: It's a good idea to open an issue first for discussion.

Checklist

@supersmo supersmo requested review from a team as code owners May 30, 2022 12:53
@google-cla
Copy link

google-cla bot commented May 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 30, 2022
Copy link

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@supersmo thanks for this PR! 😃

I've made some edits; @leahecole and I can take it from here. 👍

@ace-n ace-n added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dandhlee dandhlee changed the title Fix post so retries are actually performed fix: update post so retries are actually performed Jun 1, 2022
@dandhlee dandhlee merged commit 29abc0a into GoogleCloudPlatform:main Jun 1, 2022
@supersmo supersmo deleted the patch-1 branch June 1, 2022 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in functions/helloworld/sample_http_test_integration.py. Race condition. Post is not retried.
5 participants