chore(cloudsql): add consistent region tags #8250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
enocom
approved these changes
Aug 9, 2022
dandhlee
requested changes
Aug 10, 2022
There was a problem hiding this comment.
Could you file an issue, then add a TODO(link-to-issue) above the older region tags to be deleted?
For example:
TODO (https://github.com/GoogleCloudPlatform/python-docs-samples/issues/8000): delete older region tags
# [START cloud_sql_mysql_sqlalchemy_connect_tcp]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds region tags that match the other languages. A future
commit will remove the old region tags.