Skip to content

Fix ml_engine tests #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 14, 2017
Merged

Fix ml_engine tests #850

merged 2 commits into from
Mar 14, 2017

Conversation

elibixby
Copy link
Contributor

  • Rename tf_records -> examples everywhere, since TFRecords is technically a misnomer (or rather the name for the file container format for a number of tf.train.Example proto [or really any proto])

  • Move both JSON and EXAMPLE tests to a new model, so that they share a common expected output

  • Hopefully fix python 3 compat

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2017
@elibixby elibixby requested review from theacodes and puneith March 14, 2017 01:23
@elibixby
Copy link
Contributor Author

Can't get the py35 tests to run locally @jonparrott . I get the following error:

https://gist.github.com/elibixby/ac829c83972c4fb9f5a3c8ff16d87e9f

@theacodes
Copy link
Contributor

@elibixby travis seems fine with py35, might be your local install. Merging.

@theacodes theacodes merged commit ffae2ed into master Mar 14, 2017
@theacodes theacodes deleted the fixpredict branch March 14, 2017 16:12
@elibixby
Copy link
Contributor Author

The failure was in the slow tests. I've kicked off https://jenkins.on2flixcloud.tv/view/python/job/python-doc-samples/731/ to verify they work in Jenkins

Linchin pushed a commit that referenced this pull request Aug 18, 2025
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants