Skip to content

chore(GAE Python3): add HTTP retries to flaky test #8882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 13, 2023
Merged

chore(GAE Python3): add HTTP retries to flaky test #8882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
271027d
chore(GAE Python3): add HTTP retries to flaky test
Jan 9, 2023
fb239bc
Use backoff + requests.raise_for_status()
Jan 10, 2023
1fa547d
Propagate changes to other samples
Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions appengine/standard_python3/bundled-services/blobstore/django/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/")

yield project_id, version_id

Expand Down
9 changes: 9 additions & 0 deletions appengine/standard_python3/bundled-services/blobstore/flask/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/")

yield project_id, version_id

Expand Down
11 changes: 9 additions & 2 deletions appengine/standard_python3/bundled-services/blobstore/wsgi/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import json
import re
import subprocess
import time
import uuid

import backoff
Expand Down Expand Up @@ -66,8 +65,16 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/")

time.sleep(10) # There may be a short delay before responsive
yield project_id, version_id

gcloud_cli(f"app versions delete {version_id}")
Expand Down
9 changes: 9 additions & 0 deletions appengine/standard_python3/bundled-services/deferred/django/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/counter/get")

yield project_id, version_id

Expand Down
9 changes: 9 additions & 0 deletions appengine/standard_python3/bundled-services/deferred/flask/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/counter/get")

yield project_id, version_id

Expand Down
9 changes: 9 additions & 0 deletions appengine/standard_python3/bundled-services/deferred/wsgi/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/counter/get")

yield project_id, version_id

Expand Down
9 changes: 9 additions & 0 deletions appengine/standard_python3/bundled-services/mail/django/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/")

yield project_id, version_id

Expand Down
9 changes: 9 additions & 0 deletions appengine/standard_python3/bundled-services/mail/flask/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,15 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/")

yield project_id, version_id

Expand Down
9 changes: 9 additions & 0 deletions appengine/standard_python3/bundled-services/mail/wsgi/main_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,15 @@ def version():
result = gcloud_cli(f"app deploy --no-promote --version={uuid.uuid4().hex}")
version_id = result["versions"][0]["id"]
project_id = result["versions"][0]["project"]
version_hostname = f"{version_id}-dot-{project_id}.appspot.com"

# Wait for app to initialize
@backoff.on_exception(backoff.expo, requests.exceptions.HTTPError, max_tries=3)
def wait_for_app(url):
r = requests.get(url)
r.raise_for_status()

wait_for_app(f"https://{version_hostname}/")

yield project_id, version_id

Expand Down