Translate unicode #901
Merged
Translate unicode #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f50574d to
bc4f12f
Compare
theacodes
reviewed
Apr 17, 2017
translate/cloud-client/snippets.py
Outdated
| @@ -1,4 +1,6 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: iso-8859-15 -*- | |||
There was a problem hiding this comment.
You shouldn't need to specify an encoding in this file.
theacodes
reviewed
Apr 17, 2017
translate/cloud-client/snippets.py
Outdated
| from google.cloud import translate | ||
| from six import python_2_unicode_compatible |
There was a problem hiding this comment.
Oh no, not this. If text comes from the command line you should just be able to do text.encode('utf-8'). You' won't even have to reference the specific type (bytes/str).
|
@dpebot will you merge when travis passes? |
|
Okay! I'll merge when all statuses are green and all reviewers approve. |
theacodes
approved these changes
Apr 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.