Skip to content

Conversation

m-strzelczyk
Copy link
Contributor

Adding this method as a separate file and sample, as I want to be able to link to it from python-compute README and potentially from the cloud docs page.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Feb 9, 2023
@m-strzelczyk m-strzelczyk marked this pull request as ready for review February 14, 2023 11:53
@m-strzelczyk m-strzelczyk requested review from a team as code owners February 14, 2023 11:53
@snippet-bot
Copy link

snippet-bot bot commented Feb 14, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@leahecole
Copy link
Collaborator

for files that previously existed, they should preserve their original copyright year

@m-strzelczyk
Copy link
Contributor Author

@leahecole they do. There are 2 new files with 2023, the two modified only have the replicated copyright header removed, nothing changed apart from that.

@m-strzelczyk
Copy link
Contributor Author

Tests for 3.11 are failing due to misconfiguration, not because of this code. I'm merging as tests for other versions work well.

@m-strzelczyk m-strzelczyk merged commit ebf05af into main Feb 20, 2023
@m-strzelczyk m-strzelczyk deleted the lro-sample branch February 20, 2023 14:24
telpirion pushed a commit that referenced this pull request Mar 13, 2023
…sample (#9104)

* docs(samples): Adding the LRO handling method as a separate file and sample

* Renaming the sample region

---------

Co-authored-by: Remigiusz Samborski <rsamborski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants