Skip to content

fix: restore python 3.11 in samples docker image #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 15, 2023
Merged

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Feb 15, 2023

Towards #8873

This change was originally made in #8861 and reverted in #9003. The reason for reverting the change is because of an issue where the docker build step would time out. The samples docker image is no longer built on the fly in presubmits and we no longer have the docker build step.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 15, 2023
@parthea parthea marked this pull request as ready for review February 15, 2023 16:21
@parthea parthea requested a review from a team as a code owner February 15, 2023 16:21
Copy link
Contributor

@m-strzelczyk m-strzelczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@parthea
Copy link
Collaborator Author

parthea commented Feb 15, 2023

Merging as these changes are not tested during presubmits and this specific change was previously merged into main in #8861.

@parthea parthea merged commit 8c1aef3 into main Feb 15, 2023
@parthea parthea deleted the parthea-patch-1 branch February 15, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants