Skip to content

chore: remove unused host from URL in SQL Server samples #9157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2023
Merged

chore: remove unused host from URL in SQL Server samples #9157

merged 2 commits into from
Feb 21, 2023

Conversation

jackwotherspoon
Copy link
Contributor

In latest version of sqlalchemy-pytds library #9145, the host param has become optional in the SQLAlchemy engine URL, our samples previously had a dummy value of localhost set to fulfill the required host param. Now that it is optional, we can remove localhost from the URL for simplicity and to avoid confusion.

@jackwotherspoon jackwotherspoon requested a review from a team February 21, 2023 16:12
@jackwotherspoon jackwotherspoon self-assigned this Feb 21, 2023
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner February 21, 2023 16:12
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudsql labels Feb 21, 2023
dandhlee
dandhlee approved these changes Feb 21, 2023
View reviewed changes
Copy link
Collaborator

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the users know how to use host param if required?

@jackwotherspoon
Copy link
Contributor Author

@dandhlee

Will the users know how to use host param if required?

The users should never have the host needed or be required for the samples being updated here. The SQLAlchemy creator argument bypasses all URL params. It was only being set to localhost as a workaround to a bug in the underlying library.

@jackwotherspoon jackwotherspoon changed the title chore: update SQL Server samples to not require host param in URL chore: remove unused host from URL in SQL Server samples Feb 21, 2023
@jackwotherspoon jackwotherspoon added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 21, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 21, 2023
@jackwotherspoon jackwotherspoon merged commit 67c4076 into main Feb 21, 2023
@jackwotherspoon jackwotherspoon deleted the sql-server-samples branch February 21, 2023 17:59
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@jackwotherspoon @telpirion
chore: update SQL Server samples to not require host (#9157)
7334be2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enocom enocom enocom approved these changes

@dandhlee dandhlee dandhlee approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
api: cloudsql samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackwotherspoon @enocom @dandhlee @kokoro-team