Skip to content

Changed the endpoint from v1beta1 to v1 #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2017

Conversation

rhaertel80
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2017
@theacodes
Copy link
Contributor

@elibixby can you review? I think we did this intentionally.

@theacodes theacodes requested a review from elibixby April 27, 2017 16:56
@elibixby
Copy link
Contributor

@rhaertel80 Do I need to redeploy the models as v1 models in order to send prediction requests to the v1 endpoint (I feel like I should know this)

@puneith
Copy link
Contributor

puneith commented Apr 27, 2017

Why should the model need to be re-deployed? I am looking forward to @rhaertel80 answer on this.

@rhaertel80
Copy link
Contributor Author

Models deployed to v1beta1 (which has been officially deprecated and will be gone in < 2 months) are available on v1 under most circumstances, in particular if they are a SavedModel.

Given the deprecation status, we do need users to start migrating to v1 and this change is one step towards that.

@rhaertel80 rhaertel80 closed this Apr 30, 2017
@elibixby elibixby reopened this May 1, 2017
@elibixby
Copy link
Contributor

elibixby commented May 1, 2017

@rhaertel80 I'm going to test this locally and then I'll merge.

Copy link
Contributor

@elibixby elibixby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an additional reversioning. Tested locally, since Jenkins is down. All tests passed after rerunning because of flakey timeouts (server's cold instance increased latency to blame). Merging

@elibixby elibixby merged commit 0a3e0c5 into GoogleCloudPlatform:master May 18, 2017
Linchin pushed a commit that referenced this pull request Aug 18, 2025
* chore: Update gapic-generator-python to 1.23.6

PiperOrigin-RevId: 738170370

Source-Link: googleapis/googleapis@3f1e17a

Source-Link: https://github.com/googleapis/googleapis-gen/commit/9afd8c33d4cae610b75fa4999264ea8c8c66b9d2
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOWFmZDhjMzNkNGNhZTYxMGI3NWZhNDk5OTI2NGVhOGM4YzY2YjlkMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants