Skip to content

Upgrade flex storage sample app to python 3.11. #9236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade flex storage sample app to python 3.11. #9236

wants to merge 1 commit into from

Conversation

jinglundong
Copy link
Contributor

@jinglundong jinglundong commented Mar 7, 2023 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Guidelines from AUTHORING_GUIDE.MD
  • README is updated to include all relevant information
  • Tests pass: nox -s py-3.9 (see Test Environment Setup). Answer: doesn't work on my local machine due to a permission issue.
  • Lint pass: nox -s lint (see Test Environment Setup)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Please merge this PR for me once it is approved.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample

@jinglundong jinglundong requested review from a team as code owners March 7, 2023 03:13
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: storage Issues related to the Cloud Storage API. labels Mar 7, 2023
@jinglundong
Copy link
Contributor Author

The public bucket used in the main_test.py doesn't seem to be public any more. This PR tried to update it but I don't see the newly created public bucket though.

gsutil ls gs://python-docs-samples-tests-public
AccessDeniedException: 403 jinglun@google.com does not have storage.objects.list access to the Google Cloud Storage bucket. Permission 'storage.objects.list' denied on resource (or it may not exist).

@jinglundong
Copy link
Contributor Author

Oh, nice! The CI user has sufficient cloud IAM permission to the test bucket python-docs-samples-tests-public. All checks have passed. Please take a look.

@jinglundong
Copy link
Contributor Author

After a discussion with the Docs team, I may need to move this sample to a different directory.

@jinglundong
Copy link
Contributor Author

I moved this sample code to a new directory. Please review #9251 instead.

@jinglundong jinglundong closed this Mar 7, 2023
@jinglundong jinglundong deleted the flex-storage branch March 7, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@engelke engelke

@m-strzelczyk m-strzelczyk

Labels
api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jinglundong @engelke @m-strzelczyk