Add Cython utils needed for zero-copy import and export. #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelp
approved these changes
Apr 22, 2021
eriknw
added a commit
to eriknw/grblas
that referenced
this pull request
Apr 22, 2021
This currently works with the PR: GraphBLAS/python-suitesparse-graphblas#9 Of course, this PR won't pass until we have package on conda-forge for `suitesparse-graphblas`
|
This allows I still want to move some initialization logic for calling |
|
This can also be done defensively, call GxB_Global_Option_get() and if it
GrB_PANICs then the library is not initialized.
…On Thu, Apr 22, 2021 at 5:07 PM Erik Welch ***@***.***> wrote:
This allows grblas to be a pure Python package: python-graphblas/python-graphblas#84
<python-graphblas/python-graphblas#84>
I still want to move some initialization logic for calling GxB_init to
suitesparse_graphblas so that pygraphblas and grblas don't both try to
initialize GraphBLAS.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6BCKQ6J2VSAEORE6CXFLTKC23VANCNFSM43NDJYBQ>
.
|
|
Whoops, I just saw your comment @michelp! Yeah, each library could check using such a mechanism. I defined
I think this is ready for final review and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add a few tests for this code, but it may be sufficient if
grblastests pass.