Add initial insertion mode errors #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
previously approved these changes
Sep 5, 2017
source
Outdated
| @@ -100158,6 +100158,15 @@ dictionary <dfn>StorageEventInit</dfn> : <span>EventInit</span> { | |||
| rules don't apply any additional restrictions, make their way into the DOM.</p> | |||
|
|
|||
| <tr> | |||
| <td><dfn data-x="parse-error-non-conforming-doctype">non-conforming-doctype</dfn> | |||
| <td><p>This error occurs if the parser encounters the <span | |||
| data-x="syntax-doctype">DOCTYPE</span> that is correctly placed as a document preamble and that | |||
There was a problem hiding this comment.
data-x="syntax-doctype">DOCTYPE that is correctly placed as a document preamble and that
source
Outdated
| <td> | ||
| <p>This error occurs if the parser encounters any content other than <span | ||
| data-x="syntax-comments">comments</span> or <span>ASCII whitespace</span> before <span | ||
| data-x="syntax-doctype">DOCTYPE</span> in the beginning of the document, i.e. DOCTYPE is not |
There was a problem hiding this comment.
data-x="syntax-doctype">DOCTYPE in at the beginning of the document, i.e. DOCTYPE is not
|
@pmdartus Thank you for the review. Fixed all nits, can you take yet another look and approve it if it's good to go, please? |
pmdartus
approved these changes
Sep 5, 2017
inikulin
added a commit
that referenced
this pull request
Mar 18, 2018
* Add initial insertion mode errors * Fix review nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @HTMLParseErrorWG/core