-
Notifications
You must be signed in to change notification settings - Fork 1
Define SectorUnitRange
and refactor GradedUnitRange
#22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
===========================================
+ Coverage 81.57% 95.48% +13.91%
===========================================
Files 29 19 -10
Lines 939 665 -274
===========================================
- Hits 766 635 -131
+ Misses 173 30 -143
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
For non-group categories, my intuition would be to just accept that for those cases, |
In those cases, I guess the types |
This PR is a work in progress for a refactor of
GradedUnitRange
, following the interface defined in https://gist.github.com/ogauthe/b22450c66b5ad937db47b49cd8e6b1cb.This implementation does not use
LabelledNumbers
. Instead it is based on a "full range", which take into account multi-dimensional irreps:There is still work to be done to update all methods. Some interface choices are open for discussion (accessors...). However I realized there is an issue with the current plan: it cannot handle non-group categories. Indeed the objective is to have
length(full_range) == quantum_dimension
and to iterate on the axis to reach any state. This is not compatible with non-integer quantum dimension. Concerning structure,Base.OneTo
,BlockedUnitRange
andBlockedOneTo
imposeInteger
eltype, we cannot directly use them with e.g. Fibonacci.The problem is serious, there is a real incompatibility between iterating on an axis and non-integer length. There are several possibilities:
length = quantum_dimension
and keep the currentlength = multiplicity
convention.