Skip to content

Added locale/zh_CN #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2022
Merged

Added locale/zh_CN #1038

merged 1 commit into from
Aug 27, 2022

Conversation

skys215
Copy link
Contributor

@skys215 skys215 commented Aug 26, 2022

Added simplified Chinese locale files.

@mitulgolakiya mitulgolakiya merged commit 453d1d3 into InfyOmLabs:develop Aug 27, 2022
@skys215
Copy link
Contributor Author

skys215 commented Sep 1, 2022 •
edited
Loading

@mitulgolakiya Shouldn't the locale file also include delete in the crud.php? When there's a create, usually also has a delete.

@mitulgolakiya
Copy link
Member

@skys215 good catch. Yes, it should have. Please feel free to put a PR. I will merge it in high priority.

@skys215
Copy link
Contributor Author

skys215 commented Sep 1, 2022

Does the position of delete matters? Should it be at the bottom of the file or it could be anywhere that make sense (after the back or edit)?

@mitulgolakiya
Copy link
Member

I don't think so. let's put it after save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skys215 @mitulgolakiya