Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added super reaction #1240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added super reaction #1240

wants to merge 1 commit into from

Conversation

RealYusufIsmail
Copy link
Contributor

@RealYusufIsmail RealYusufIsmail commented Apr 16, 2023 •
edited by felldo
Loading

Checklist

Changelog

  • Added support for super reactions
  • Added Rest error code 90002

Description

Closes: #1238

Footnotes

  1. At least started a running bot instance with your changes and triggered an event so your changed code gets executed. ↩

@RealYusufIsmail
Copy link
Contributor Author

Dont how I can test this as I don't have nitro

@RealYusufIsmail RealYusufIsmail force-pushed the super-reactions branch 2 times, most recently from 35a0492 to a44d1dc Compare April 16, 2023 11:15
@Saladoc Saladoc marked this pull request as draft April 16, 2023 11:16
@Saladoc
Copy link
Member

Saladoc commented Apr 16, 2023

Test what you can without nitro, write a list of what you tested and what you couldn't test, then find someone who can test the rest.

@feddevanderlist
Copy link
Contributor

Dont how I can test this as I don't have nitro

If you setup something in a server and invite me I might be able to do a test run for you.

@RealYusufIsmail
Copy link
Contributor Author

Dont how I can test this as I don't have nitro

If you setup something in a server and invite me I might be able to do a test run for you.

sure will do so.

@RealYusufIsmail
Copy link
Contributor Author

Dont how I can test this as I don't have nitro

If you setup something in a server and invite me I might be able to do a test run for you.

Sent the invite link for a test server via discord

@RealYusufIsmail
Copy link
Contributor Author

image

@RealYusufIsmail RealYusufIsmail marked this pull request as ready for review August 17, 2023 16:42
@RealYusufIsmail RealYusufIsmail requested a review from felldo August 30, 2023 10:44
@RealYusufIsmail RealYusufIsmail force-pushed the super-reactions branch 5 times, most recently from 187b475 to 9a742ec Compare August 31, 2023 20:20
@felldo
Copy link
Member

felldo commented Aug 31, 2023

The PR I showed you in #1240 (comment) also shows that theres a new field for the message reaction remove event which you currently do not handle at all

@RealYusufIsmail
Copy link
Contributor Author

The PR I showed you in #1240 (comment) also shows that theres a new field for the message reaction remove event which you currently do not handle at all

Oh sorry totally forgot about the one.

@RealYusufIsmail RealYusufIsmail force-pushed the super-reactions branch 3 times, most recently from 7bed9d5 to 9bc5746 Compare September 1, 2023 16:39
@RealYusufIsmail
Copy link
Contributor Author

The PR I showed you in #1240 (comment) also shows that theres a new field for the message reaction remove event which you currently do not handle at all

Should be done now

@RealYusufIsmail RealYusufIsmail force-pushed the super-reactions branch 4 times, most recently from e384bca to df6d151 Compare October 27, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felldo felldo Awaiting requested review from felldo

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add super reactions
4 participants
@RealYusufIsmail @Saladoc @feddevanderlist @felldo