Skip to content

Adds onPaste validation, fix adds with decimal and toPresicion bug #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds onPaste validation, fix adds with decimal and toPresicion bug #21

wants to merge 1 commit into from

Conversation

nachodd
Copy link

@nachodd nachodd commented May 18, 2021

  • Adds onPaste handler that check if the actual value pasted is a valid Numeric value.
  • Corrects a bug when adding or subtracting numbers with decimals.
  • Fix toPresicion fn bug: If the initial value is an integer, it fails to apply toFixed

@nachodd
Adds onPaste validation, fix addition with decimal problem and toPres…
e99941a 
…icion bug

- Adds onPaste handler that check if the actual value pasted is a valid Numeric value.
- Corrects a bug when adding or subtracting numbers with decimals. 
- Fix toPresicion fn bug: If the initial value is an integer, it fails to apply toFixed
@nachodd
Copy link
Author

nachodd commented May 18, 2021

I've also created another validations, like disabling the "e" to be entered (as input type number supports scientific notation, but is rarely used). If you want, I can create another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nachodd