add insert! #376
Merged
add insert! #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nalimilan - I have added |
bkamins
commented
Nov 20, 2021
bkamins
commented
Nov 20, 2021
bkamins
commented
Nov 20, 2021
nalimilan
reviewed
Nov 20, 2021
| @@ -232,6 +234,31 @@ using CategoricalArrays: DefaultRefType, leveltype | |||
| @test x.pool.levels == x2.pool.levels | |||
| @test x.pool.invindex == x2.pool.invindex | |||
|
|
|||
| x = y | |||
There was a problem hiding this comment.
Can you add the equivalent code to 12_missingarray.jl? These files should be kept in sync. (Or just leave both files alone as tests in 13_arraycommon.jl may be enough.)
bkamins
commented
Nov 20, 2021
|
Thanks! If you like we can make a minor release, otherwise we can wait a bit more until we have other features to ship. |
|
No rush. For your reference I have opened the PR because users wanted to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #375