[RFC] For DOM children, use repr(MIME("text/html", x))
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the improvement, Tom! I think this looks good. Re: escaping, I think the intention was always to protect against HTML content being injected through content that may be provided by user input. This change does mean that one can bypass the sanitization mechanism with a custom type if that type represents user input and implements HTML escaping incorrectly, but I don't think there's any principled way to prevent that other than fixing the bug in the source package. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, HTML content can be nested inside
Node's. This means a package user can include Markdown inside a node and have the HTML representation of that embedded. Likewise, a DataFrame will have its HTML representation included. Here is an example:I'm not sure what the impact is on escaping. This branch passes tests locally.