Only strip pkcs8 header for Private Keys (Fixes Issue #85) #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also address build warning about an unused variable
|
This was referenced Feb 5, 2025
|
@dannys42 - Will need you to pull this in before I can do the releasing and then the tagging of 1.0.203 for cocoapods |
|
@dannys42 - Not sure how to get the Travis CI Build to start working... seems like it's looking for an install script in the https://github.com/Kitura/Package-Builder repo that isn't there??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix unit test failure due to stripping the header of all pkcs8 keys - instead of JUST the private keys.
Motivation and Context
Seeing a unit test failure in Xcode 15 & 16, when targeting Mac or iPhone Simulator.
How Has This Been Tested?
Verified successful unit tests
Checklist: