feat: add EIP1559 tx type support #827
Merged
+1,612
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't go nuts trying to pull latest versions which inevitably will need new rust versions
There was a problem hiding this comment.
Pull Request Overview
Add EIP-1559 transaction type support to PKPEthersWallet, enabling both manual and automatic fee settings based on network support.
- Introduce
EIP1559_TX_TYPEconstant and setters for manual EIP-1559 fee fields - Extend
signTransactionlogic to fetch and apply fee data or fallback to legacy gasPrice - Update Rust toolchain version and adjust
.gitignorefor Cargo.lock
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/wasm/rust/rust-toolchain.toml | Specify Rust toolchain channel 1.83 with WebAssembly target |
| packages/wasm/rust/.gitignore | Remove Cargo.lock from ignore to include it in the repo |
| packages/pkp-ethers/src/lib/pkp-ethers.ts | Add EIP-1559 support: constant, setters, reset logic, and feeData handling in signTransaction |
Comments suppressed due to low confidence (2)
packages/pkp-ethers/src/lib/pkp-ethers.ts:162
- [nitpick] Add unit tests for
setMaxFeePerGasandsetMaxPriorityFeePerGasto ensure manual EIP-1559 settings are applied correctly.
setMaxFeePerGas = (maxFeePerGas: string): void => {
packages/wasm/rust/.gitignore:3
- [nitpick] Verify that re-including
Cargo.lockin the repo aligns with project conventions; libraries typically ignore it, while applications commit it.
bin/
…eat/eip-1559 23.81.180.7 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQCVcVPlYm+nxd2l+v2d3r3op8nUz+inhOGj7bmJf6iW9EzHg5hcmaDVBhTaShIa4Exotq1TOBZsRBE2WcpoBvbEJam2Gp6SShe2P6Upe1oWbiW124jfRaHHc+Tm+eTN039ofBrFjCgWWIYPxP+BzvQ3FSbB4u6DDgZs0IHy7KOjjnoc9bCJNIxLNjdzwmCRfGfuPcPi8v3J9dWj+anTWvRnrVRNrJXE669Mo0QA0xz45JdBjJ8wjMonZSBf4dsLDNCrWIjUmOxpvpziBbo7KStEuGkuxv71NFVGxnGGvSHvyJx3CICrwrtF/SmYmG2jpuepDiIyyNVzqMQ7rdgenloMifYbHUf67H/AhV6m8Xx4UtpqTo3MDiZhGp/xNshX6LE7GY0B2mLsQWvKe6xBO4+9Iha1cH3X9gcRs1FkAJTJjRWzDFly44D5FeHcrNTz/cKOOQRzlXNvbyzRwMHKz7U/Z8XcVW7LgJVVXxGZ8rW7T7n0cL/Ds7GMjXMogUJjdFk=
glitch003
approved these changes
Aug 5, 2025
|
works great in my local tests with walletconnect + PKPEthers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
add EIP 1559 support