[Alpha] [Naga] To be released #833
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the "Naga" alpha release branch containing significant architectural changes to the Lit Protocol SDK. It migrates from AccsOperatorParams to OperatorAcc types, introduces new access control conditions schemas with Zod validation, adds new package structure and tooling, and implements major build system updates with dependency management.
- Architectural migration to Zod-based schema validation for access control conditions
- Introduction of new @lit-protocol/access-control-conditions-schemas package
- Major build system refactoring with new dependency management and automation
Reviewed Changes
Copilot reviewed 271 out of 1511 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/access-control-conditions/src/lib/canonicalFormatter.ts | Migrates from AccsOperatorParams to OperatorAcc type, adds new imports and interface definitions |
| packages/access-control-conditions/src/lib/canonicalFormatter.spec.ts | Updates test structure with better error handling and type improvements |
| packages/access-control-conditions/src/lib/booleanExpressions.ts | New utility for validating boolean expressions in access control conditions |
| packages/access-control-conditions/src/index.ts | Adds new exports for boolean expressions and builder functions |
| packages/access-control-conditions/project.json | Adds new build targets including dependency checking and publishing |
| packages/access-control-conditions/package.json | Version bump to 8.0.0-alpha.14 with new dependencies |
| packages/access-control-conditions-schemas/* | New package containing Zod schemas for access control condition validation |
| local-tests/tests/wrapped-keys/* | Removes wrapped-keys test files |
| package.json | Major build system overhaul with new scripts and dependency management |
| nx.json | Build system configuration updates for new dependency management |
| } from '@lit-protocol/types'; | ||
|
|
||
| interface ABIParams { | ||
| name: string; | ||
| type: string; | ||
| } | ||
|
|
There was a problem hiding this comment.
The ABIParams interface is defined locally but seems to duplicate functionality. Consider using a shared type definition or importing from a common location to avoid duplication.
| } from '@lit-protocol/types'; | |
| interface ABIParams { | |
| name: string; | |
| type: string; | |
| } | |
| AbiParam, | |
| } from '@lit-protocol/types'; |
Copilot uses AI. Check for mistakes.
| "main": "./src/index.js", | ||
| "typings": "./src/index.d.ts", |
There was a problem hiding this comment.
The version indicates this is an alpha release (8.0.0-alpha.14), but the main and typings paths point to src/ instead of dist/. This suggests development setup rather than published package configuration.
| "main": "./src/index.js", | |
| "typings": "./src/index.d.ts", | |
| "main": "./dist/index.js", | |
| "typings": "./dist/index.d.ts", |
Copilot uses AI. Check for mistakes.
| @@ -0,0 +1,70 @@ | |||
| { | |||
| "name": "access-control-conditions-schemas", | |||
| "$schema": "../../node_modules/nx/access-control-conditions-schemas/project-schema.json", | |||
There was a problem hiding this comment.
The schema path includes the package name 'access-control-conditions-schemas' which is unusual for Nx project schemas. This should likely be the standard Nx schema path.
| "$schema": "../../node_modules/nx/access-control-conditions-schemas/project-schema.json", | |
| "$schema": "../../node_modules/nx/schemas/project-schema.json", |
Copilot uses AI. Check for mistakes.
Base Naga Branch