Skip to content

[INF-607] Follow Up: Add workflow to e2e Tests #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 7, 2025
Merged

[INF-607] Follow Up: Add workflow to e2e Tests #850

merged 3 commits into from
Aug 7, 2025

Conversation

kapoorabhishek24
Copy link
Contributor

Description

Pull request refactors the E2E Tests and Health Checks workflow.

The key changes are:

  • Removed Matrix Strategy: The workflow no longer uses a matrix strategy. Instead, each job now performs a single repository checkout and dependency installation, then runs the network health checks as sequential steps.
  • Updated Default Branch: The default branch for the naga-health-check job has been updated from naga to master to align with current repository standards.

Type of change

  • New feature (non-breaking change which adds functionality)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Garandor
Garandor reviewed Aug 6, 2025
View reviewed changes
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more nit and we're good, pls use shallow clones wherever possible

fetch-depth: 1

@Ansonhkg Ansonhkg merged commit 6eef0b1 into master Aug 7, 2025
3 of 5 checks passed
@Ansonhkg Ansonhkg deleted the inf-607-github-ci-e2e-tests branch August 7, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garandor Garandor Garandor left review comments

@Ansonhkg Ansonhkg Awaiting requested review from Ansonhkg Ansonhkg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kapoorabhishek24 @CLAassistant @Garandor @Ansonhkg