Skip to content

Update the title when changing the problem #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2019
Merged

Update the title when changing the problem #214

merged 3 commits into from
Mar 17, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Mar 17, 2019

Fix #210

@jdneo jdneo added this to the 0.13.1 milestone Mar 17, 2019
@jdneo jdneo requested a review from Vigilans March 17, 2019 11:26
Vigilans
Vigilans previously approved these changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@Vigilans Vigilans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another issue:
When the preview window is open but hidden, click another problem node, and the preview window won't be revealed.

Could be improved in next version.

Vigilans
Vigilans approved these changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@Vigilans Vigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my side, LGTM.

@jdneo jdneo merged commit 54777e8 into master Mar 17, 2019
@jdneo jdneo deleted the cs/bug branch March 17, 2019 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Vigilans Vigilans Vigilans approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jdneo @Vigilans