Skip to content

Can specify the node path #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 1, 2019
Merged

Can specify the node path #233

merged 3 commits into from
Apr 1, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Mar 25, 2019

Resolve: #227

This can be a solution for those users who use the 3-party shell, like zshell on Mac, causing Node.js not found.

@jdneo jdneo added this to the 0.13.2 milestone Mar 25, 2019
@jdneo jdneo requested review from poppinlp and Vigilans March 25, 2019 12:22
Vigilans
Vigilans reviewed Mar 25, 2019
View reviewed changes
@Vigilans
Copy link
Contributor

Vigilans commented Apr 1, 2019

Tested without problem on my side (Behavior: when changed the path config and focus out, the settings page will refresh).

@jdneo jdneo merged commit c6c4e9c into master Apr 1, 2019
@jdneo jdneo deleted the cs/node-path branch April 1, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poppinlp poppinlp Awaiting requested review from poppinlp

1 more reviewer

@Vigilans Vigilans Vigilans approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jdneo @Vigilans