WebSocket Server is not closing properly!! #610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WSclient_t * newClient(WEBSOCKETS_NETWORK_CLASS * TCPclient); Is now public
d-a-v
reviewed
Jan 17, 2021
src/WebSocketsServer.cpp
Outdated
| @@ -913,7 +913,7 @@ void WebSocketsServer::begin(void) { | |||
| } | |||
|
|
|||
| void WebSocketsServer::close(void) { | |||
| WebSocketsServer::close(); | |||
| WebSocketsServerCore::close(); | |||
There was a problem hiding this comment.
I apologize for the mistake !
|
ok the github build in conflict resolver bad. changes all line space and line endings... |
Links2004
added a commit
that referenced
this pull request
Jan 19, 2021
|
changes have been manually merge to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change a few things in order to make this lib work on esp8266 on Async mode using platformio.
But the main reason on this pull request is the mistake on line 916 on WebSocketsServer, the function is calling itself in a eternal loop that will end up eventually breaking the code.
Fix is simple, instead of WebSocketServer::close(), just reference to the proper one WebSocketServerCore::close().