Skip to content

To do: refactor/clarify workings behind dac, adc, and direct wrsamp on physical units #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cx1111 opened this issue Feb 7, 2018 · 1 comment
Closed

To do: refactor/clarify workings behind dac, adc, and direct wrsamp on physical units #103

cx1111 opened this issue Feb 7, 2018 · 1 comment
Assignees
@Lucas-Mc
Labels
enhancement

Comments

@cx1111
Copy link
Member

cx1111 commented Feb 7, 2018

The wrsamp function calls a lot of functions behind the scenes. Performing adc and such. These functions should be documented and clarified.
@cx1111 cx1111 mentioned this issue Jun 22, 2018
Closed
@Lucas-Mc Lucas-Mc self-assigned this May 4, 2020
@Lucas-Mc
Copy link
Contributor

Lucas-Mc commented May 4, 2020

This is a good idea and I am currently working on it! I am also going to make this more broad by adding better documentation and docstrings for all the functions in general.

Lucas-Mc added a commit that referenced this issue May 4, 2020
@Lucas-Mc
Improves documentation #103
82930b8 
Adds docstrings to functions that need them and amends the current docstrings to relfect recent untracked changes.
Lucas-Mc added a commit that referenced this issue May 6, 2020
@Lucas-Mc
Merge pull request #207 from MIT-LCP/add_doc_103
f4ada09 
Improves documentation #103
@Lucas-Mc Lucas-Mc closed this as completed May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lucas-Mc Lucas-Mc

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cx1111 @Lucas-Mc