Skip to content

Add option for user to adjust numpy datatype #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Lucas-Mc opened this issue Jun 1, 2020 · 0 comments
Closed

Add option for user to adjust numpy datatype #225

Lucas-Mc opened this issue Jun 1, 2020 · 0 comments
Assignees
Labels

Comments

@Lucas-Mc
Copy link
Contributor

Lucas-Mc commented Jun 1, 2020

Add parameter in rdrecord/rdsamp for user to select their desired numpy datatype since the default now is float64 and this appears to cause MemoryError with larger datasets. See #224.

It should be noted that rdrecord currently has a return_res parameter though this only converts the dtype after the data has already been imported and manipulated in the float64 format.

@Lucas-Mc Lucas-Mc self-assigned this Jun 1, 2020
@Lucas-Mc Lucas-Mc added the bug label Jun 1, 2020
Lucas-Mc added a commit that referenced this issue Jun 2, 2020
Adds a datatype parameter in the rdrecord and rdsamp functions to allow the user to increase computation speed at the expense of accuracy and significant figures of signal data. Fixes #224 and #225.
Lucas-Mc added a commit that referenced this issue Jun 2, 2020
Adds datatype parameter in rdrecord/rdsamp #224 #225
@Lucas-Mc Lucas-Mc closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant