-
Notifications
You must be signed in to change notification settings - Fork 314
Difference in results after changing to 3.0.1 from 2.2.1 #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @venkatesh71097, do you have any more specifics about the database and files than "p00"? One thing to note is that version >=3.0.0 shifted from Physiobank to Physionet which means it is using the most updated versions of the databases and, in some cases, some content may have changed. The underlying functionality in the code should still be the same but let's see what we can figure out here! Thanks for posting! |
Hey, so I'm trying to check the number of patients having 'PLETH' channel in p00 file of the mimic matched subset database that was released a month back, as I want only the pleth channel from the signals. It is from physionet.org. I've p00 files placed in my directory. Let me know if you need any further details. |
Hey @venkatesh71097, do you have any code that can reproduce this issue? I want to check the specific differences between the two versions when replicating this bug that you are receiving. Thanks! |
import pandas as pd count_hea = 0 Hey lucas , you can try this out. Sorry for the delay. I missed the notification! |
Hey @venkatesh71097, I just downloaded the files locally and ran your code and reproduced both numbers. One file it failed on was For now, you can catch the |
Fixes error when using the return_res parameter which can sometimes modify the format in which the data from file is read. This oftentimes creates illogical arrays which can't be recovered into the proper values or even the proper shape. Fortunately, the removal of this does not significantly affect the runtime of the function even for large arrays. Fixes #230.
I made the fix and got the same number for both the current Github version and 2.2.1. Hope this helps! |
Hello!
I recently pip installed the latest wfdb version onto my system. I see that the results are drastically changing. Like, I had to calculate the number of patients having one particular column of data. With version 2.2.1, I was getting 341 for p00 file. But, with latest wfdb package, I'm getting just 272. I'm not sure what kind of a glitch this is. I reverted back to 2.2.1 to try out, once I got a reduced count of result in 3.0.1, and it worked fine.
The text was updated successfully, but these errors were encountered: