-
Notifications
You must be signed in to change notification settings - Fork 314
Downloads fail on Windows #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
same,not solved |
Quick workaround... (could break other db downloads)
Modified (version concatenation commented)
|
The issue is that the os.sep should be replaced with a "/" in the if cited by @jlnbotello, as the url uses / and not \ |
You are right @lbugnon !!! if '/' not in db_dir:
db_url = posixpath.join(config.db_index_url, db_dir , record.get_version(db_dir))
else:
db_url = posixpath.join(config.db_index_url, db_dir) |
Replaces `os.sep` with `/` to indicate a URL and prevent issues on Windows machines since `os.sep` on Windows is '\'. Fixes #262.
Thanks for the catch @lbugnon! Silly mistake during development which didn't show up on my Mac 🤦 This reminds me and further increases my desire to add Windows OS testing to Travis.. hopefully to be implemented soon! |
Uh oh!
There was an error while loading. Please reload this page.
Hi, URL generation is failing in windows when using dl_database, For example
here "/1.0.0" is repeated
The text was updated successfully, but these errors were encountered: