Skip to content

Downloads fail on Windows #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbrose opened this issue Apr 11, 2017 · 1 comment
Closed

Downloads fail on Windows #40

kbrose opened this issue Apr 11, 2017 · 1 comment

Comments

@kbrose
Copy link
Contributor

kbrose commented Apr 11, 2017

Main problem is prevalence of using os.path.join() to create URLs, on Windows this will use backslashes to join the arguments instead of forward slash, ending up with errors like

>>> import wfdb; import os; wfdb.dldatabasefiles('ltstdb', os.getcwd(), ['s20011.hea', 's20011.dat'], overwrite=True)
Downloading files...
multiprocessing.pool.RemoteTraceback:
... < SNIP > ...
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http://physionet.org/physiobank/database/ltstdb%5Cs20011.hea

(of course %5C is a backslash).

Probably want to use posixpath instead?

@gloryren
Copy link

Main problem is prevalence of using os.path.join() to create URLs, on Windows this will use backslashes to join the arguments instead of forward slash, ending up with errors like

>>> import wfdb; import os; wfdb.dldatabasefiles('ltstdb', os.getcwd(), ['s20011.hea', 's20011.dat'], overwrite=True)
Downloading files...
multiprocessing.pool.RemoteTraceback:
... < SNIP > ...
requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http://physionet.org/physiobank/database/ltstdb%5Cs20011.hea

(of course %5C is a backslash).

Probably want to use posixpath instead?

have solved this?
i have this problem now, and i check WFDB have use posixpath now ,but why still this happened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants