Skip to content

Windows compatibility #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 14, 2017
Merged

Conversation

kbrose
Copy link
Contributor

@kbrose kbrose commented Apr 11, 2017

Adding windows compatibility to download commands.

See #40.

@kbrose
Copy link
Contributor Author

kbrose commented Apr 12, 2017

This gets me down from 13 errors to 2 errors when running nosetests on windows. The 2 remaining errors are truly mysterious to me (problems with _headers.inttypes). If this gets merged then I'll make an Issue for those and try and get them fixed.

@kbrose
Copy link
Contributor Author

kbrose commented Apr 12, 2017

Still not quite sure why the part fixed in ed8fcb6 wasn't working on my machine, but I believe the change should be a little more robust anyway. With that commit I have no errors when running nosetests locally.

@cx1111
Copy link
Member

cx1111 commented Apr 14, 2017

Thanks for your help.

@cx1111 cx1111 merged commit 2500e38 into MIT-LCP:master Apr 14, 2017
@kbrose kbrose deleted the windows-compatibility branch September 21, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants