Skip to content

updated regex to correctly parse units #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

updated regex to correctly parse units #232

merged 1 commit into from
Jun 9, 2020

Conversation

maksteel
Copy link

@maksteel maksteel commented Jun 9, 2020

Fixes #231

with the change the output is

        sig_name   units  adc_res  init_value  checksum  block_size
0           Chin      uV       15           0     24244           0
1       Left Leg      uV       15           0     22989           0
2      Right Leg      uV       15           0    -22154           0
3  CPAP Pressure  mcmH2O       15           0    -24985           0
4      CPAP Flow   l/min       15           0    -22447           0
5      CPAP Leak   l/min       15           0     10563           0
6       Light_BU       m       15           0     17314           0
7       XFlow_DR    mV/s       15           0    -12675           0

@maksteel
Copy link
Author

maksteel commented Jun 9, 2020 •
edited
Loading

Regex with and without the change

@Lucas-Mc
Copy link
Contributor

Lucas-Mc commented Jun 9, 2020

Very nice work!! That's my first time using regex101 and I'll probably be using it again soon!

@Lucas-Mc Lucas-Mc added the bug label Jun 9, 2020
@Lucas-Mc Lucas-Mc merged commit 9b97885 into MIT-LCP:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

units are not parsed correctly
2 participants
@maksteel @Lucas-Mc