Fix reading formats 8, 310, and 311 #327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Format 8 (not to be confused with format 80) is a format in which each sample is stored as an 8-bit difference from the previous sample. This was handled incorrectly; for example:
This format is rarely used (should not be used) nowadays, but it remains supported by WFDB, so handling it incorrectly will give misleading results. Note that
wr_dat_file
doesn't support writing this format and I'm inclined to keep it that way.Formats 310 and 311 are two different formats that store 10-bit samples as four-byte blocks of three samples each. These formats were handled correctly for the most part, but they would crash if
sampto
was not divisible by 3; for example:wr_dat_file
doesn't support writing either of these formats, but would be worth adding them in the future.