Relax matplotlib dependency for Google Colab #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 2022-05-26, a certain popular cloud computing service comes with matplotlib 3.2.2 preinstalled, along with other packages that will cause a conflict if you try to install the latest version of matplotlib (3.5.2). I'm not aware of any incompatibilities with this version, so relax wfdb's requirement in order to make installation smoother.
tompollard
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #374: when you create a notebook in Google Colab (https://colab.research.google.com/), it comes pre-configured with a bunch of pip packages by default. Some of those pre-installed packages will conflict with what you get if you try to run
pip install --upgrade matplotlib.Fortunately, the pre-installed environment already includes matplotlib, just not the latest version.
AFAIK, there should not be any problem using wfdb with matplotlib 3.2.2, so we can relax this requirement to make it easier for people to use the package with Colab.
Remember, when you run
pip install wfdbin a fresh environment, it will always give you the latest versions that satisfy wfdb's dependencies. So most people runningpip install wfdbwill still get matplotlib 3.5.2.