Allow custom labels in field2bytes #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4fcf271 to
99a4737
Compare
cx1111
reviewed
Jul 5, 2022
|
Also, I'm curious to know: why do you want to write WFDB annotation files? Trying to get a gauge of what's useful and where to focus future efforts, thanks. |
We were trying to write the custom beat labels into WFDB annotation format. import wfdb
import numpy as np
import pandas as pd
ann_idx = np.array([0, 1000, 2000, 3000, 4000, 5000, 6000, 7000])
ann_label_store = np.array([ 4, 4, 1, 2, 2, 3, 2, 3])
ann_chan = np.array([3, 1, 2, 3, 4, 5, 6, 7])
ann_custom_labels = {'label_store': [1, 2, 3, 4], 'symbol': ['v', 'l', 'r', 'z'], 'description': ['pvc', 'lbbb', 'rbbb', 'pac']}
ann_custom_labels = pd.DataFrame(data=ann_custom_labels)
wfdb.wrann('A0001', 'atr', ann_idx, chan=ann_chan, label_store=ann_label_store,custom_labels=ann_custom_labels)However, there is an error as follows. After we checked the code and found out the python code never use custom_labels to store the symbol/labels. So my colleague tries to fix the bug that allows storing custom labels in WFDB annotation format. The test code that we use: import wfdb
import numpy as np
import pandas as pd
ann_idx = np.array([1, 1000, 2000, 3000, 4000, 5000, 6000, 7000])
ann_chan = np.array([3, 1, 2, 3, 4, 5, 6, 7])
# write custom labels
ann_label_store = np.array([ 4, 4, 1, 2, 2, 3, 2, 3])
ann_custom_labels = {'label_store': [1, 2, 3, 4], 'symbol': ['v','l','r','z'], 'description':['pvc','lbbb','rbbb','pac']}
ann_custom_labels = pd.DataFrame(data=ann_custom_labels)
wfdb.wrann('A0001', 'atr', ann_idx, chan=ann_chan, custom_labels=ann_custom_labels, label_store=ann_label_store)
# read
ann = wfdb.rdann('A0001', 'atr')
print(ann.sample)
print(ann.custom_labels)
print(ann.symbol)
print(ann.label_store)
print(ann.chan)After fixed the result: |
|
Thank you. I've added a test case to the pytest suite in f01a151. Please let me know if this needs some code style changes, or anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #399
Take custom labels into account in encoding, should they exist by temporarily creating a larger version of ann_label_table including custom labels.