Skip to content

Clarify #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2017
Merged

Clarify #77

merged 3 commits into from
Oct 3, 2017

Conversation

cx1111
Copy link
Member

@cx1111 cx1111 commented Oct 3, 2017

  • Properly implement adc/dac conversion for record objects.
  • Changes input parameter names and documentation of several processing functions: gqrs_detect, compute_hr, correct_peaks. Mainly just change words 'peaks_indexes' to peak_indices but also some other variable names to be consistent with the rest of the wfdb functions.
  • Moved HR example notebook to demo.ipynb and made some slight changes to it to load physical signals.
  • Changed the README examples to reflect changes. Also fix wrong examples.

@Dubrzr Let me know if you approve.

cx1111 added 3 commits October 2, 2017 20:17
…cessing variables, move and change heart rate and gqrs demo. Update function documentation. Correct all cases of dac and adc. Update readme to capture new changes.
@Dubrzr
Copy link
Collaborator

Dubrzr commented Oct 3, 2017

Perfect! You did a great job! Do you plan to create a documentation for this library? The documentation could automatically generate images of the examples at each update (I've already done that before with Sphinx)

@cx1111 cx1111 merged commit d58286c into master Oct 3, 2017
@cx1111 cx1111 deleted the clarify branch October 3, 2017 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants